Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the download link component #3468

Closed
wants to merge 2 commits into from

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Dec 9, 2024

What

  • Remove the download link component (added here)
  • Also, adjust the map mobile spacing

See https://government-frontend-pr-3468.herokuapp.com/foreign-travel-advice/algeria

Why

It can be replaced with the attachment link component.

Visual changes

Before (mobile)

After (mobile)

Before (tablet)

www gov uk_foreign-travel-advice_algeria(iPad Pro)

After (tablet)

government-frontend dev gov uk_foreign-travel-advice_algeria(iPad Pro)

Anything else

See alphagov/govuk_publishing_components#3483.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3468 December 9, 2024 09:44 Inactive
@jon-kirwan jon-kirwan force-pushed the replace-the-download-link-component branch from 0686ca3 to ba5d2c8 Compare December 9, 2024 10:22
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3468 December 9, 2024 10:22 Inactive
@jon-kirwan jon-kirwan force-pushed the replace-the-download-link-component branch from ba5d2c8 to 6358791 Compare December 9, 2024 10:43
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3468 December 9, 2024 10:44 Inactive
@jon-kirwan jon-kirwan marked this pull request as ready for review December 9, 2024 10:44
@jon-kirwan
Copy link
Contributor Author

Closed due to #3426

@jon-kirwan jon-kirwan closed this Jan 6, 2025
@jon-kirwan jon-kirwan deleted the replace-the-download-link-component branch January 6, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review attachment-link component usage
2 participants